Address all 18 findings from code review council audit#49
Open
Address all 18 findings from code review council audit#49
Conversation
Security fixes: - C1: Certificate validator rejects in production, accepts only in debug - S1: API tokens redacted from WebSocket URI logs with URI sanitizer - M7: Documented API key binary baking risk in environment config Testing: - C2: Added 49 unit tests for WebSocketService (20), WebSocketDataSyncService (14), CertificateValidator (15 pre-existing) Architecture & code quality: - M8: Extracted ActionCable handshake into ActionCableAuthService (165 → 65 lines) - M1: Documented core→features dependency as tech debt - M10: Documented vestigial REST API config with deprecation notice - L4: Added warning log for web platform header limitation Reliability & error handling: - M2: syncInitialData returns bool (true=success, false=timeout) - M3: Reconnect concurrency guard with _isReconnecting flag - M4: Pending requests failed immediately on disconnect() - M5: Heartbeat watchdog only runs when sendClientPing enabled - M6: Cache writes have .catchError() handlers - M9: Room cache race condition fixed with chained futures Other: - L1: Test mocks properly used instead of real StorageService - L2: Uuid used instead of Random() for request IDs - L3: Not a real issue in Dart's single-threaded model (documented) - S2: Backend data contracts investigated and documented Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code